search

shopware / development

MIT License
189 stars 169 forks source link

Configurable docker image and php version #125

Closed giacmir closed 3 years ago

giacmir commented 4 years ago

With this PR the image used by docker-compose is configurable by .psh.yaml. This allows to:

  1. Change PHP version for development and testing purposes
  2. Change the docker image used (e.g. to add xdebug support by changing it to webdevops/php-apache-dev instead of webdevops/php-apache)

without having to do changes to version controlled files.

cakebake commented 3 years ago

A change that I make every time to have xDebug available without stress. Just wanted to open a PR and saw this one.

The PHP version does not necessarily have to be changeable, especially since it has to match the rest of the packages (composer.json, etc.).

shopwareBot commented 3 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14267

Please use this issue to track the state of your pull request.

philipreinken commented 3 years ago

Thank you for contributing @giacmir ! 🥳