shopware / development

MIT License
189 stars 170 forks source link

Add support for bundled private composer dependencies via path repo #141

Closed felixbrucker closed 3 years ago

felixbrucker commented 3 years ago

In v6.4.0.0 Shopware will add support for plugins which manage their dependencies via composer:

Currently with this upcoming change in Shopware v6.4.0.0, there is a need to also support private dependencies which you bundle with the plugin. This PR enables the usage of private dependencies through a path repo packages within each plugin directory.

The plugins directory structure would thus look like this:

MyAwesomePlugin
├── packages
│   └── my-private-dependency/
│       ├── composer.json
│       └── src/
│           └── SomeCoolService.php
├── src/
│   └── MyAwesomePlugin.php
└── composer.json

and the plugins composer.json would require the private dependency like any other dependency:

"require": {
    "my-vendor-name/my-private-dependency": "^1.2.3",
}
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

mitelg commented 3 years ago

hey @felixbrucker thanks for that :+1: I guess this is also needed in https://github.com/shopware/production

felixbrucker commented 3 years ago

Yes, just created the PR over there: https://github.com/shopware/production/pull/80

shopwareBot commented 3 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14332

Please use this issue to track the state of your pull request.

J-Rahe commented 3 years ago

Hey @felixbrucker, your PR was just merged :)

J-Rahe commented 3 years ago

@felixbrucker, i've opened an PR in our new docs for this, maybe you want to comment on it?