NEXT-37979 - Fix input arrow up and down issue

shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.

https://shopware.design

MIT License

18 stars 3 forks source link

NEXT-37979 - Fix input arrow up and down issue #261

Closed tajespasarela closed 2 weeks ago

tajespasarela commented 3 weeks ago

What?

This MR fixes the issue in the sw-number-field component when pressing the up or down arrow keys if a new value was typed.

Why?

Before the fix, when the user types some value in a number field and after pressing the arrow up key or arrow down key, the new value is incorrect.

How?

The solution was to update the internal value on any key input. This way when the arrow keys are pressed, the actual value is there.

Testing?

Test cases were added

To manually testing:

Go to components-form-mt-number-field--docs
Focus in the input and type some number
Without moving the focus from the field press arrow up or arrow down.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
meteor-component-library	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 5, 2024 7:24am

1 Skipped Deployment

pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@261

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@261

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@261

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@261

commit: e7f7c47