NEXT-38027 - fix datepicker not emiting value when manually entered

shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.

https://shopware.design

MIT License

19 stars 4 forks source link

NEXT-38027 - fix datepicker not emiting value when manually entered #270

Closed tajespasarela closed 2 months ago

tajespasarela commented 2 months ago

What?

This MR fixes an issue with the mt-datepicker, that provokes not saving the date when it is typed manually instead of selected from the calendar.

How?

The solution was to emit the changed value also in the onClose hook of the flatpicker component. This way when user clicks save, it will be emitted.

There is another hook onValueUpdate but this is emitted multiple times when typed and it is not emitted when the date is deleted manually. So the onClose hook works better.

It was also necessary to update the flatpickr dependency to latest version to fix some inconsistent behaviour.

Testing?

go to Should emit date value when manually typed in storybook

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
meteor-component-library	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 0:22am

1 Skipped Deployment

pkg-pr-new[bot] commented 2 months ago

commit: 922b799

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@270

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@270

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@270

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@270

Open in Stackblitz

tajespasarela commented 2 months ago

Please add a changelog by using npx changesets

done