search

shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.
https://shopware.design
MIT License
18 stars 3 forks source link

Improve a11y of password field component #272

Closed Haberkamp closed 2 weeks ago

Haberkamp commented 2 weeks ago

What?

This PR makes the button for the password field accessible.

Why?

This allows users to toggle the password visibility via the keyboard.

How?

I replaced the span element with a button element.

Testing?

You can checkout the changes in the branch preview below.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:19am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **meteor-admin-sdk-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/shopware-frontends/meteor-admin-sdk-docs/ptWLNZo7QeU1VV5yYuH8o5NQPjme)) | [Visit Preview](https://meteor-admin-sdk-docs-git-improve-a11-31758f-shopware-frontends.vercel.app) | | Sep 3, 2024 0:19am |
pkg-pr-new[bot] commented 2 weeks ago

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@272
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@272
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@272
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@272

commit: 8502513