shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.

https://shopware.design

MIT License

19 stars 3 forks source link

remove scss from modal #273

Closed Haberkamp closed 2 months ago

Haberkamp commented 2 months ago

What?

Removes the SCSS from the modal component.

Why?

This gets us closer to the goal of getting rid of SCSS.

How?

I replaced the SCSS with plain css.

Testing?

The visual tests should catch everything.

Anything else

This PR has no changelog because it's only a refactor and does not have any effect on users of this package.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
meteor-admin-sdk-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 3, 2024 0:50am
meteor-component-library	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 3, 2024 0:50am

pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@273

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@273

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@273

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@273

commit: 311f72e