Closed Haberkamp closed 1 day ago
vercel[bot]
commented
1 day ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| meteor-component-library | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 18, 2024 1:33pm |
pkg-pr-new[bot]
commented
1 day ago pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@298pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@298pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@298pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@298commit: 519f7cb
What?
This PR adds a future flag for adding the default margin.
Why?
Components should work in isolation. Adding a default margin to every component breaks that concept. Having a default margin ties the component to a specific context that it should work in. Once the component is used outside of that context you have to work around it. Make modifications to that component i.e. remove the default margin from the component.
That new behavior is how every other component library out there does it. There's no default bottom margin for that component. If you want to add some space between the components you have to do that through the parent component or add a custom class on top of that component to add some spacing.
How?
I've added a new future flag. By default it is disabled. But if you want you can enable it. This will remove the default bottom margin for the components.
Testing?
You can test it yourself by adding a theme provider at the top of the application and setting the
removeDefaultMargintotrueScreenshots (optional)
Anything Else?
Right now this only works for the
mt-tabscomponent.