search

shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.
https://shopware.design
MIT License
18 stars 3 forks source link

remove default margin from checkbox #302

Closed Haberkamp closed 18 hours ago

Haberkamp commented 23 hours ago

What?

This PR removes the default margin from the checkbox component.

Why?

The parent component should take care of spacing elements. Not the component itself.

How?

I've removed the default margin depending on whether or not the removeDefaultMargin future flag is activated or not.

Testing?

The visual tests should catch issues. But feel free to test it yourself by checking out the story for the checkbox.

Anything Else?

vercel[bot] commented 23 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 0:25am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **meteor-admin-sdk-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/shopware-frontends/meteor-admin-sdk-docs/Et2NdpbAbvnAT9ThgkFFp81oDpT6)) | [Visit Preview](https://meteor-admin-sdk-docs-git-remove-defa-c65e9b-shopware-frontends.vercel.app) | | Sep 19, 2024 0:25am |
pkg-pr-new[bot] commented 18 hours ago

Open in Stackblitz

pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-admin-sdk@302
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-component-library@302
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-icon-kit@302
pnpm add https://pkg.pr.new/shopware/meteor/@shopware-ag/meteor-tokens@302

commit: 0fe58b8