shopware / meteor

Meteor is Shopware’s open-source design system that drives our commerce solutions. Extend and customise every aspect of Shopware – create elegant, delightful, and accessible experiences. There are no limits to your imagination.
https://shopware.design
MIT License
18 stars 3 forks source link

remove default margin from base field #303

Open Haberkamp opened 23 hours ago

Haberkamp commented 23 hours ago

What?

This PR remove the default margin for the base field and therefore for many of the form elements.

Why?

The parent component should always take care of spacing elements, not the element itself.

How?

The default margin gets removed when the removeDefaultMargin future flag is enabled.

Testing?

The visual tests should catch every issue, but feel free to test it out yourself using the branch preview below.

Anything Else?

vercel[bot] commented 23 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:36am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **meteor-admin-sdk-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/shopware-frontends/meteor-admin-sdk-docs/B8bpCSbii6ZWvFVrKPiSuw3Fe3H5)) | [Visit Preview](https://meteor-admin-sdk-docs-git-remove-defa-fb3c94-shopware-frontends.vercel.app) | | Sep 19, 2024 8:36am |