Add auth.json to .gitignore

shopware / production

Shopware 6 production template

https://shopware.com

175 stars 152 forks source link

Add auth.json to .gitignore #139

Closed Schrank closed 2 years ago

Schrank commented 2 years ago

Stelle sicher, dass sich die Datei auth.json in .gitignore befindet, um zu verhindern, dass Zugangsdaten in den Git-Verlauf gelangen

Translation to englisch: Make sure, that the file auth.json is in your gitignore to avoid that credentials are part of your git history

CLAassistant commented 2 years ago

All committers have signed the CLA.

keulinho commented 2 years ago

From https://getcomposer.org/doc/articles/authentication-for-private-packages.md#authentication-in-auth-json-per-project i guess :wink:

LGTM :+1:

shopwareBot commented 2 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-20168

Please use this issue to track the state of your pull request.

Schrank commented 2 years ago

From https://getcomposer.org/doc/articles/authentication-for-private-packages.md#authentication-in-auth-json-per-project i guess 😉

Nope, from your info about how to install plugin via composer:

By the way: Can you please write "SAVE YOUR F*CKING TOKEN BEFORE INSTALL" in bigger letters, underlined and bold on this modal? I'm always overlooking it :-/

keulinho commented 2 years ago

Thanks @Schrank for your contribution! :tada: :blue_heart:

I'm not sure about the UI change you suggest and where to put the request, maybe @shyim knows more.

shyim commented 2 years ago

I will report it to the correct team :)

Btw for the pro users:

shopware-cli account login
shopware-cli account merchant shop configure-composer <your-domain> (PS: Tab works as autocomplete)

Looks like this then

❯ shopware-cli account merchant shop configure-composer shym.shopware.in
INFO The composer token is a1179988ffcfdb2bc1809ad18bxxxxx
INFO Found composer.json, adding it now as repository