search

shopware / production

Shopware 6 production template
https://shopware.com
177 stars 151 forks source link

align asset command to avoid confusion #163

Closed quisse closed 2 years ago

quisse commented 2 years ago

The command asset:install works because symfony translates this to assets:install. When searching everywhere for asset:install there are no results except for those in build scripts. As it has no added value to shorten the command in a shell, it is more clear to write the full command.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

keulinho commented 2 years ago

Hey @quisse, thanks for your contribution! Your are completely right, we should use the correct name of the command here.

But please sign the Contibutor License Agreement, otherwise we can't proceed and can't accept your PR. It seems that you used a mail address as the committer address, that is not associated with your GitHub account. Please add the email address you used to commit also to your GitHub account, or reopen another PR where you use a email address that is already associated to you account to commit.

quisse commented 2 years ago

@keulinho woops! Fixed it 👍

shopwareBot commented 2 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23727

Please use this issue to track the state of your pull request.

keulinho commented 2 years ago

Hey @quisse, thanks again for your contribution, your changes are merged now! :tada: :blue_heart: