shopware / production

Shopware 6 production template
https://shopware.com
177 stars 151 forks source link

Override default php-fpm pool #22

Closed fbdo closed 4 years ago

fbdo commented 4 years ago

When we install php-fpm, by default it's created a www.conf file with standard configuration for a pool named "www". The fpm-pool.conf configures a pool with the same name, and when we run the Docker container the fpm-pool.conf is completely ignored. I renamed the "fpm-pool.conf" file to "www.conf" to override the existing file and apply the project configuration.

claudiobianco commented 4 years ago

Depending on how this is intended, you could also add it as "zz-fpm-pool.conf" in order to load it after "www.conf" (which is done alphabetically afaik) so that it will only override the included settings?

fbdo commented 4 years ago

Hi @claudiobianco , we can keep the old file and the new, but I normally prefer explicit, purposeful code/config other than an implicit knowledge, more fragile, based on order, where if someone by any means, renames the file, we will have the same problem again. Any reason to keep the old file in the Docker image?

claudiobianco commented 4 years ago

No, it was more meant as an additional option. I guess it depends a bit on wether all the settings are the same if the www.conf is there or not since you only set a few values in fpm-pool.conf.

Since I'm not that familiar with php configuration I like to keep it as a point of reference.

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

shopwareBot commented 4 years ago

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.

For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.