shopware / production

Shopware 6 production template

https://shopware.com

177 stars 151 forks source link

escape the source variable, so that directories with spaces can be used #64

Closed dominikmank closed 3 years ago

dominikmank commented 4 years ago

when having a path like /Users/My Name/Workspace/.env it will become broken and the .env file can't be "sourced"

shyim commented 4 years ago

We should run shell check

dominikmank commented 4 years ago

Hey @shyim , i run it through https://www.shellcheck.net/ now . Only the ENV_FILE variable is "not ok" now - but i don't know how to fix this. Do you have a hint here?

shyim commented 4 years ago

The error is just saying it cannot find the file there are some comments to specifiy it like

shellcheck source=xxx.sh

But its okay for me so :).

shopwareBot commented 3 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14748

Please use this issue to track the state of your pull request.

pweyck commented 3 years ago

I've extended the PR a bit and added shellcheck to our pipeline. I've merged this into 6.4.

Thank you for your contribution 👍