TestBootstrapper forced Shopware install uses stale plugins configuration

[DCoderLT]

PHP Version

8.2

Shopware Version

6.5.0.0

Expected behaviour

When I use TestBoostrapper and force a Shopware reinstall, the system should not execute any code from plugins before plugins are actually registered.

Actual behaviour

When \Shopware\Core\Kernel boots, it picks up active plugins from the database. When TestBoostrapper forces a reinstall through system:install, the kernel is not rebooted after dropping the db - those active plugins are still registered, but their DB schema is now gone. After system:install drops the db and runs the core migrations, it will call dal:refresh:index. If one of those stale plugins had a service tagged shopware.entity_indexer, this service will be triggered, and i that service was not written defensively, it can crash with a missing DB table or a similar problem. If that crash happens, the test database no longer contains the problematic plugin, so the next time TestBootstrapper boots, it will not register the plugin/indexer, and the test run will complete successfully. But if the test bootstrapper installs that poisonous plugin, the next test run will crash again... and the test runner will flip-flop between running and crashing with every run.

I imagine that this is not limited to an entity indexer, and there are other scenarios where using those stale services can cause a problem.

How to reproduce

• create a plugin that:
  • creates a new db table
  • tags a service with shopware.entity_indexer
  • tries to access that new table in the indexer service
• configure phpunit's test bootstrap script to install this plugin and force install Shopware
• run phpunit, it should succeed and register the plugin
• run phpunit again, it should crash in the indexer service
• run phpunit again, it should succeed and register the plugin
• run phpunit again, it should crash in the indexer service...

[shopware-issue-bot[bot]]

We found the following existing issues which may help or are related to your topic:

• Problems with TestBootstrapper Class for Plugin that requires another Plugin
• Don't work test plugins on Shopware 6
• Ensure calling plugin is loaded in TestBootstrap.php (or a separate bootstrap file just for plugins)
• Plugin build is unpredictable
• Remove shopware storefront dependency in core
• Plugin uninstall will not work with executeComposerCommands() returning true
• plugin:refresh command should be executable without loading plugins
• Composer plugins change managedByComposer flag for required plugins

[MarcelSchmaeing]

Hi,

thx for your issue we will put it into our new evaluation process and have a look at it again.

[shopwareBot]

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37957.

[created from NEXT-37957, comment 489033]