search

shopware / shopware

Shopware 6 is an open commerce platform based on Symfony Framework and Vue and supported by a worldwide community and more than 1.500 community extensions
https://shopware.com
MIT License
2.67k stars 973 forks source link

Control settings "None" on image sliders don't work #3711

Open phit opened 2 weeks ago

phit commented 2 weeks ago

PHP Version

N/A

Shopware Version

trunk 75ae67fe948ef8c7cff910326918338bbf8db7e9

Expected behaviour

setting navigation arrows or dots for image slider or image gallery to none disables the controls

Actual behaviour

the arrows/dots stay and are no longer positioned correctly

How to reproduce

https://github.com/shopware/shopware/blob/75ae67fe948ef8c7cff910326918338bbf8db7e9/src/Storefront/Resources/views/storefront/element/cms-element-image-gallery.html.twig#L18

https://github.com/shopware/shopware/blob/75ae67fe948ef8c7cff910326918338bbf8db7e9/src/Storefront/Resources/views/storefront/element/cms-element-image-slider.html.twig#L13

All the output templates expect that selecting "None" sets the value to a falsey value or more specfically null.

But the settings in the administration appear to be broken, these should all be using :modelValue

https://github.com/shopware/shopware/blob/75ae67fe948ef8c7cff910326918338bbf8db7e9/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-slider/config/sw-cms-el-config-image-slider.html.twig#L152-L154

https://github.com/shopware/shopware/blob/75ae67fe948ef8c7cff910326918338bbf8db7e9/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-gallery/config/sw-cms-el-config-image-gallery.html.twig#L206-L208

shopware-issue-bot[bot] commented 2 weeks ago

We found the following existing issues which may help or are related to your topic:

mitelg commented 2 weeks ago

seems to be a similar issue: https://github.com/shopware/shopware/issues/3641