Removed unused key in for-each

shopware5 / SwagMigration

Shopware 5 Migration (Import from third party systems)

MIT License

17 stars 40 forks source link

Closed JoshuaBehrens closed 5 years ago

JoshuaBehrens commented 6 years ago

It is a bad style to pipe request data directly into a business logic layer. Therefore one should not check input names in logic layer.

This is a breaking change which will break https://github.com/shopwareLabs/SwagMigration/pull/31. If this gets merged I can fix this too.

shopwareBot commented 6 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-9454

Please use this issue to track the state of your pull request.

mitelg commented 5 years ago

thanks for your contribution @JoshuaBehrens :+1: :tada: :blue_heart: