search

shopware5 / SwagPaymentPaypal

A PayPal integration for shopware
http://shopware.com
MIT License
5 stars 16 forks source link

Fix-Issues-With-Missing-Addional-Address-Line #12

Closed mnaczenski closed 6 years ago

mnaczenski commented 7 years ago

When using the addional adress-line in paypal the entry won't be saved, because of the wrong field-naming.

mitelg commented 7 years ago

@shopwareBot

mitelg commented 7 years ago

@mnaczenski there are some more lines in this files. are they all affected? which SW version is it? what about older versions of SW?

mnaczenski commented 7 years ago

I added a version check to the two occurances of the additional address lines. The naming changed with the introdution of the new address-handling in 5.2.

I tested my PR in 5.1.2 and 5.3.4.

shopwareBot commented 7 years ago

Hello,

thank you for creating this pull request. I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-8612.

Please use this issue to track the state of your pull request.

PortaltechGithub commented 6 years ago

works for us, FYI

mitelg commented 6 years ago

thanks for your contribution @mnaczenski :+1: :tada:

will be part of the next release