shopware5 / SwagPaymentPaypal

A PayPal integration for shopware
http://shopware.com
MIT License
5 stars 16 forks source link

Fix AddressValidator #9

Closed FiveDigital closed 7 years ago

FiveDigital commented 7 years ago

Fix an issue causing the PHP Fatal error: Uncaught Error: Call to a member function getControllerName() on null in engine/Shopware/Plugins/Community/Frontend/SwagPaymentPaypal/Components/Paypal/AddressValidator.php:38PHP Fatal error: Uncaught Error: Call to a member function getControllerName() on null in engine/Shopware/Plugins/Community/Frontend/SwagPaymentPaypal/Components/Paypal/AddressValidator.php:38.

We ran into this problem when using the API components on CLI for a customer import.

mitelg commented 7 years ago

Hi @FiveDigital, thanks for your PR. Why did you add exactly the same condition in the if? I think the problem is already fixed with this commit: 912d223a1636609c65d64cb4016aa258d9baa37e

FiveDigital commented 7 years ago

Sorry, I just looked at my local code an did not realize that this issue has already been fixed 👎

Btw. I was looking at the last commit messages and the message for the commit you mentioned is not very appropriate ;)