shopware5 / devdocs

Shopware 5 Developers Website
https://developers.shopware.com
137 stars 228 forks source link

wrong callback name in the description under the code example #1092

Closed kokoyroy closed 2 years ago

kokoyroy commented 4 years ago

As defined in getSubscribedEvents the callback is called onFrontendPostDispatch. It takes an Enlight_Controller_ActionEventArgs object as parameter, which holds context about the event - in this case the context of the controller that has been executed.

onFrontendPostDispatch has to be onPostDispatch as in code above

mitelg commented 4 years ago

hey @kokoyroy on which page do you mean?

kokoyroy commented 4 years ago

https://developers.shopware.com/developers-guide/plugin-quick-start/#subscriber-classes

in the descrioption under the code block

mitelg commented 4 years ago

then this would be the file to edit: https://github.com/shopware/devdocs/blob/master/source/developers-guide/plugin-quick-start/index.md#subscriber-classes

maybe you like to create a PR? :blush:

kokoyroy commented 4 years ago

what is the pr? i am noob :P

mitelg commented 4 years ago

you are able to make change suggestions to the documentation code itself :blush: this is called a Pull Request (PR)

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request