search

shopware5 / shopware-vagrant

A Vagrant setup ready for shopware development
MIT License
58 stars 30 forks source link

Vagrant-Hostmanager, Grunt #33

Closed fboes closed 7 years ago

fboes commented 7 years ago

Proposing some minor changes to add support for Vagrant Hostmanager and port forwarding to allow Grunt & LiveReload to work out of the box. ;)

teiling88 commented 7 years ago

Hey @fboes, thanks for your contribution. I merged 97d1dae and f41176f from your pull request.

The Vagrant-Hostmanager is not installed by default so we don't need an integration of it for your base box at the moment.

Greetings

fboes commented 7 years ago

@teiling88 Glad to contribute. Actually I think the settings for Vagrant-Hostmanager won't do anything dangerous if there is no Vagrant-Hostmanager present - but the settings are a nice addition if the Vagrant-Hostmanager is installed.

Right now I cannot test this, but maybe someone else can… ;)

teiling88 commented 7 years ago

Actually I think the settings for Vagrant-Hostmanager won't do anything dangerous if there is no Vagrant-Hostmanager present

See the error message below without Vagrant-Hostmanager :-)

There are errors in the configuration of this machine. Please fix the following errors and try again: Vagrant:

  • Unknown configuration section 'hostmanager'.

Without Vagrant-Hostmanager the Vagrantfile is invalid.

fboes commented 7 years ago

:( Too bad. Nevermind, it still was a pleasure to contribute. :)

teiling88 commented 7 years ago

It was a pleasure! :)