Refactor Windows installation directory to accept parameter

shorebirdtech / install

The Shorebird (un)installer 🐦

Other

22 stars 9 forks source link

Refactor Windows installation directory to accept parameter #23

Closed subramanian42 closed 5 months ago

subramanian42 commented 1 year ago

Description

This pull request introduces a refactoring of the install.ps1 to enhance flexibility in specifying the installation directory for Windows environment. for the issue #22

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

bryanoltman commented 1 year ago

Nice and simple! Would you mind adding verification that this works in .github/workflows/e2e.yaml? Something like:

      - name: 📦 Install Shorebird CLI (powershell with custom path)
        if: matrix.os == 'windows-latest'
        run: ./install.ps1 InstallDirectory=/path/to/wherever
        shell: pwsh

We'll also want to update https://docs.shorebird.dev/#install- to reflect this.

eseidel commented 5 months ago

@bryanoltman what would you like to do with this?

bryanoltman commented 5 months ago

This seems fairly stale and I'm not sure that it works (the PR seems to rename the installDirectory variable to InstallDirectory (note the capital 'I'), so going to close. Please resurrect if this is important to you.