fix: improved error message to provide correct command

shorebirdtech / install

The Shorebird (un)installer 🐦

Other

22 stars 9 forks source link

fix: improved error message to provide correct command #32

Closed babasahi closed 5 months ago

babasahi commented 5 months ago

Description

Closes #31
Changed error message to include the appropriate command to use if an existing shorebird installation was detected.

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

eseidel commented 5 months ago

I think my only question is if this message is going to go stale (are we going to end up changing the way we invoke this) and if so, should it be held in a constant variable instead of a string 🤷 Regardless, I defer to @bryanoltman here who wrote most of our installers I think.

bryanoltman commented 5 months ago

I think I would prefer to update the script to overwrite the existing installation. I can't imagine a case where someone is trying to run this script but has an installation they want to preserve.