search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.06k stars 122 forks source link

feat: would like patch numbers to match between iOS and Android #1382

Open eseidel opened 8 months ago

eseidel commented 8 months ago

Right now if you publish a patch to Android and then a patch to iOS (for the same app), they will end up with patch number "1" and "2" respectively. This is confusing to some users who expect the patch numbers to match for the "same patch". This also causes some complexity for us in the console and could make sense to want to allow users to just mark one patch live and have it affect all OSes.

felangel commented 8 months ago

Agreed this should be fairly straightforward to implement since it’s only a CLI change.

anderscheow commented 8 months ago

Just for my use case:

App is showing version + patch in About screen. For example 1.0.1 (13) - Patch 1

Current behaviour: Android: 1.0.1 (13) - Patch 1 iOS: 1.0.1 (13) - Patch 2

Expected behaviour: Android: 1.0.1 (13) - Patch 1 iOS: 1.0.1 (13) - Patch 1

anderscheow commented 4 months ago

@eseidel @felangel any idea when this will get implemented?

eseidel commented 4 months ago

We currently have no schedule for this, no. We were discussing something similar yesterday which is that these numbers are currently just "names" and the fact that we have them auto-increment on a per-platform basis is confusing in other contexts. We could easily change the name to something else. The underlying "id" of the patch is just our database id for the patch artifact table row.

eseidel commented 3 months ago

Dupe with https://github.com/shorebirdtech/shorebird/issues/1762?