Closed bryanoltman closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
ccfeb87
) to head (da3508a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing this in favor of requiring a target platform being specified for local engine builds (e.g., shorebird release android --local-engine-src-path=$HOME/shorebirdtech/engine/src --local-engine=android_release_arm64 --local-engine-host=host_release --target-platform=android-arm64
)
Description
Because the default value for
shorebird release android
'starget-platform
option isandroid-arm,android-arm64,android-x64
and because a local engine build targets only one of these, this PR updates the command to only use the target-platform args included inAndroidArch.availableAndroidArchs
. An alternative solution would be to require--target-platform
to be specified for local engine builds.Type of Change