shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.97k stars 118 forks source link

fix(shorebird_cli): fix release android target_platform with local_engine #1943

Closed bryanoltman closed 3 weeks ago

bryanoltman commented 3 weeks ago

Description

Because the default value for shorebird release android's target-platform option is android-arm,android-arm64,android-x64 and because a local engine build targets only one of these, this PR updates the command to only use the target-platform args included in AndroidArch.availableAndroidArchs. An alternative solution would be to require --target-platform to be specified for local engine builds.

Type of Change

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ccfeb87) to head (da3508a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1943 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 174 174 Lines 5493 5494 +1 ========================================= + Hits 5493 5494 +1 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1943/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [shorebird_cli](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1943/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `100.00% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryanoltman commented 3 weeks ago

Closing this in favor of requiring a target platform being specified for local engine builds (e.g., shorebird release android --local-engine-src-path=$HOME/shorebirdtech/engine/src --local-engine=android_release_arm64 --local-engine-host=host_release --target-platform=android-arm64)