shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.96k stars 118 forks source link

chore(shorebird_cli): use upstream googleapis_auth package #1952

Closed bryanoltman closed 3 weeks ago

bryanoltman commented 3 weeks ago

Description

Fixes https://github.com/shorebirdtech/shorebird/issues/1944

Type of Change

eseidel commented 3 weeks ago

Does this bump our minimum Dart version?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ccfeb87) to head (24dcbc9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1952 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 174 174 Lines 5493 5493 ========================================= Hits 5493 5493 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1952/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [shorebird_cli](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1952/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `100.00% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eseidel commented 3 weeks ago

We already pull our own Dart. I'm not sure what call we're making that's not using it: https://github.com/shorebirdtech/shorebird/blob/main/bin/shorebird https://github.com/shorebirdtech/shorebird/blob/main/third_party/flutter/bin/internal/shared.sh

eseidel commented 3 weeks ago

Yeah, we have our own Dart, we should just fix cases where we're using the wrong one.