search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.34k stars 142 forks source link

ci: e2e tests should not setup Flutter/Dart in advance #1955

Open felangel opened 6 months ago

felangel commented 6 months ago

Description

Installing Shorebird automatically pulls down Shorebird's Flutter and Dart so our E2E tests do not need to use the setup-flutter or setup-dart actions to pre-install a system Flutter/Dart.

We will need to adjust the e2e workflow to run flutter create using Shorebird's Flutter instead of relying on a system Flutter

eseidel commented 6 months ago

100% we shouldn't need to depend on Dart or Flutter already being installed.

It's very cheap to add secret commands to shorebird or the shorebird repo to access Shorebird's downloaded flutter/dart.

felangel commented 5 months ago

Line we should remove: https://github.com/shorebirdtech/shorebird/blob/8b21c261cbfe85bb1d1132217286da1adbf40b9a/.github/workflows/e2e.yaml#L48C6-L53C22

eseidel commented 5 months ago

https://github.com/shorebirdtech/shorebird/blob/main/.github/workflows/e2e.yaml

eseidel commented 5 months ago

Looks like we might need it for:

      - name: 🧪 Run Integration Tests
        run: dart test integration_test
        working-directory: packages/shorebird_cli

Which means this might be blocked on https://github.com/shorebirdtech/shorebird/issues/2105.