search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.97k stars 118 forks source link

CFBundleShortVersionString & CFBundleVersion Sync while Build Generation for iOS #1956

Open tirth-multipl opened 3 weeks ago

tirth-multipl commented 3 weeks ago

Description

CFBundleShortVersionString & CFBundleVersion are not sync when generating iOS build with shorebird. These are soft-warnings. ⚠️

Steps To Reproduce

shorebird release ios --flavor prod  -- --dart-define=BASE_URL=<url>

Expected Behavior

CFBundleShortVersionString & CFBundleVersion should sync when generating iOS build with shorebird.

Warnings

CFBundleShortVersionString Mismatch. The CFBundleShortVersionString value '1.15.32' of extension 'Runner.app/PlugIns/NotificationService.appex' does not match the CFBundleShortVersionString value '1.15.67' of its containing iOS application 'Runner.app'.

CFBundleVersion Mismatch. The CFBundleVersion value '2142' of extension 'Runner.app/PlugIns/NotificationService.appex' does not match the CFBundleVersion value '250' of its containing iOS application 'Runner.app'.
bryanoltman commented 3 weeks ago

If I'm understanding correctly, the issue is that your app extension version and your app version are not the same. Shorebird does not manipulate your app version or the versions of your app extensions. Are you suggesting that it should, or am I misunderstanding the problem?

tirth-multipl commented 3 weeks ago

yeah you're correct but when we do normal build generation w/o shorebird, this issue doesn't happen.

bryanoltman commented 3 weeks ago

When you say "normal build generation", what do you mean exactly? How do you normally perform your builds?

tirth-multipl commented 3 weeks ago

When you say "normal build generation", what do you mean exactly? How do you normally perform your builds?

Without Shorebird I meant.

flutter build ipa --flavor prod --dart-define=BASE_URL=<url>