shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.97k stars 118 forks source link

fix(shorebird_cli): handle multi-dimensional flavors on android #1960

Closed erickzanardo closed 3 weeks ago

erickzanardo commented 3 weeks ago

Description

Our CLI would get confused when using multi dimensional flavors on android. This PR fixes that.

Fixes #1830

Type of Change

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (09507fa) to head (47d6d05).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1960 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 176 177 +1 Lines 5520 5560 +40 ========================================= + Hits 5520 5560 +40 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1960/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [shorebird_cli](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1960/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `100.00% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.