shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.96k stars 118 forks source link

fix(shorebird_cli): select correct arch for local engine target #1963

Closed bryanoltman closed 3 weeks ago

bryanoltman commented 3 weeks ago

Description

Updates availableAndroidArchs to match on exact engine path. This fixes an issue where --target-platform=android-arm64 would incorrectly match android-arm (i.e., arm32) and return the wrong architecture, causing the release command to fail.

Type of Change

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ad3be55) to head (43b40d0). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1963 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 177 177 Lines 5560 5560 ========================================= Hits 5560 5560 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1963/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [shorebird_cli](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1963/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `100.00% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.