shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
1.97k stars 118 forks source link

fix: revert " update cache artifacts on every command run" #1975

Closed felangel closed 3 weeks ago

felangel commented 3 weeks ago

Description

Reverts https://github.com/shorebirdtech/shorebird/pull/1958

Reverting this change because for customers patching or releasing using older flutter revisions, this change results in the cache only downloading artifacts for the latest stable engine revision instead of the engine revision being used to patch/release.

Also filed #1976 to prevent this type of regression in the future.

Type of Change

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (65e0e56) to head (3856414).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1975 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 177 177 Lines 5562 5564 +2 ========================================= + Hits 5562 5564 +2 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [shorebird_cli](https://app.codecov.io/gh/shorebirdtech/shorebird/pull/1975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `100.00% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.