search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.31k stars 140 forks source link

fix: running Shorebird in Powershell on Windows sets `FLUTTER_STORAGE_BASE_URL` to https://download.shorebird.dev #2108

Closed bryanoltman closed 5 months ago

bryanoltman commented 5 months ago
  1. Open a Powershell terminal
  2. Navigate to a Flutter app directory
  3. Execute flutter run
  4. Notice that "Flutter assets will be downloaded from https://download.shorebird.dev. Make sure you trust this source!" is not printed
  5. Run shorebird init
  6. Execute flutter run
  7. Notice that "Flutter assets will be downloaded from https://download.shorebird.dev. Make sure you trust this source!" is printed.

This should not be happening. Running shorebird should not set environment variables.

bryanoltman commented 5 months ago

Additional info: This only seems to happen when the flutter invocation in https://github.com/shorebirdtech/shorebird/blob/main/bin/shorebird.ps1 fails