search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.31k stars 140 forks source link

feat: `shorebird release` should save off build arguments and `shorebird patch` should use them #2407

Open eseidel opened 2 months ago

eseidel commented 2 months ago

Right now it's possible to pass one set of --dart-defines when releasing and a different one when patching.

Maybe that's a feature? But it also feels like maybe something we should automatically match for you (or at least offer to?) when patching. Otherwise you could accidentally end up with a much larger patch than you expect.

eseidel commented 3 weeks ago

Similarly it's possible to pass --obfuscate to one but not the other (which can cause confusing results).

Even if we didn't use them, there are probably some flags we should save/check-for between the two.