shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.27k stars 135 forks source link

fix: When i try to patch a release im getting bunch of errors #2527

Open Anikets08 opened 1 week ago

Anikets08 commented 1 week ago

command used: shorebird patch android --release-version 0.062.99+1559 --flavor dev -- --dart-define=flavor=dev

i have added log below

1728643449267_shorebird.log

bryanoltman commented 1 week ago
[        ] Execution failed for task ':app:signDevReleaseBundle'.
[        ] > A failure occurred while executing com.android.build.gradle.internal.tasks.FinalizeBundleTask$BundleToolRunnable
[        ]    > java.lang.NullPointerException (no error message)

This appears as though you have not properly configured the keystore used to sign release builds. Take a look at the official documentation that explains how to do so.

Anikets08 commented 1 week ago

I'm signing the app properly using this action

and just after this i have an action to create patch to previous version

- name: Build Android Patch
  run: |
    export SHOREBIRD_TOKEN="${{ inputs.SHOREBIRD_API_KEY }}"
    yes | shorebird patch android --release-version ${{ inputs.TAG_VERSION }} --flavor ${{ inputs.FLAVOR }} -- --dart-define=flavor=${{ inputs.FLAVOR }}
  shell: bash

- name: Build iOS Patch
  run: |
    export SHOREBIRD_TOKEN="${{ inputs.SHOREBIRD_API_KEY }}"
    yes | shorebird patch ios --release-version ${{ inputs.TAG_VERSION }} --flavor ${{ inputs.FLAVOR }} -- --dart-define=flavor=${{ inputs.FLAVOR }}
  shell: bash
bryanoltman commented 4 days ago

If you force the flutter build command in the Build Release to execute, does it succeed?

Anikets08 commented 3 days ago

yes before shorebird we were using flutter build command and it was working fine

eseidel commented 44 minutes ago

[ ] Caused by: org.gradle.workers.internal.DefaultWorkerExecutor$WorkExecutionException: A failure occurred while executing com.android.build.gradle.internal.tasks.FinalizeBundleTask$BundleToolRunnable Which presumably is gradle trying to run bundle-tool. Not sure why bundle-tool would fail (this is presumably gradle fetching a copy of bundle-tool rather than the one we fetch for shorebird.

eseidel commented 43 minutes ago

Oh, I see @bryanoltman commented above, that this is a keystore issue. That they may be set up correctly for debug builds but not release builds.

Can you please confirm that flutter build aab works for you? If it doesn't, fixing that first is required for Shorebird to work.