search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.36k stars 142 forks source link

feat: Explain which assets have changed in Assets.car #2638

Open vasilich6107 opened 2 days ago

vasilich6107 commented 2 days ago

Description

I changed button label to test the release

Currently I'm getting 

[WARN] Your app contains asset changes, which will not be included in the patch.
    Changed files:
        Products/Applications/Runner.app/Assets.car

as far as I can see you are comparing assets in a smart way https://github.com/shorebirdtech/shorebird/pull/1103

The --verbose command gives 10k of logs which is not really hepfull

Requirements

Additional Context

No

vasilich6107 commented 1 day ago

Could it be related to the fact that we are adding badge to the icon during build phase?

bryanoltman commented 1 day ago

Could it be related to the fact that we are adding badge to the icon during build phase?

This is almost certainly it. Assets.car is a file that contains assets for native iOS apps, and app icons are included in this.

vasilich6107 commented 1 day ago

Thanks for quick response @bryanoltman and for your hard work

It would be nice to have some kind of explanation what is changed in assets to make things more transparent.