search

shorebirdtech / shorebird

Code Push for Flutter and other tools for Flutter businesses.
https://shorebird.dev
Other
2.31k stars 140 forks source link

feat: `shorebird upgrade` should compile `shorebird` #289

Open eseidel opened 1 year ago

eseidel commented 1 year ago

I believe flutter upgrade does this. Right now when you run shorebird upgrade it will replace your shorebird, but not recompile it. This means that the next time you run a shorebird command it does the compile.

Maybe the fix for this and https://github.com/shorebirdtech/shorebird/issues/288 is to just have it run shorebird --version?

eseidel commented 1 year ago

It should also compile flutter. Otherwise you can get awkward later compiles of Flutter, like when you run shorebird doctor:

eseidel@Erics-MacBook-Pro test_app % shorebird doctor

Shorebird v0.0.5

✓ Flutter install is correct (23.4s)
✓ AndroidManifest.xml files contain INTERNET permission (29ms)
✓ Shorebird is up-to-date (0.3s)

No issues detected!
eseidel commented 1 year ago

And call flutter --version to compile flutter.

yahu1031 commented 11 months ago

Wasn't this fixed?

Hoping a simple and feasible solution is in upgrade_command.dart


++ await doctor.runValidators(doctor.allValidators, applyFixes: false); // No need to apply any fixes. Just a doctor is fine like flutter does.

updateProgress.complete('Updated successfully.');

return ExitCode.success.code;

@eseidel @felangel

bryanoltman commented 5 months ago

Originally thought this would be part of https://github.com/shorebirdtech/shorebird/pull/2184, but was wrong. Unassigning for now.