shorebirdtech / updater

libupdater code for Shorebird
Other
66 stars 13 forks source link

fix(patch): statically link C runtime for Windows patch binaries #129

Closed bryanoltman closed 7 months ago

bryanoltman commented 7 months ago

Description

Adds a .cargo/config file to the patch library to statically link the C runtime for windows builds. As per https://github.com/rust-lang/rust/issues/100874.

Fixes https://github.com/shorebirdtech/shorebird/issues/1487

Type of Change

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.66%. Comparing base (c484e4a) to head (f6f931b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ======================================= Coverage 96.66% 96.66% ======================================= Files 21 21 Lines 2786 2786 ======================================= Hits 2693 2693 Misses 93 93 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/updater/pull/129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Ξ” | | |---|---|---| | [patch](https://app.codecov.io/gh/shorebirdtech/updater/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `45.33% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.