shorebirdtech / updater

libupdater code for Shorebird
Other
66 stars 13 forks source link

fix: verify failed patch is next_boot_patch before clearing #149

Closed bryanoltman closed 5 months ago

bryanoltman commented 5 months ago

Description

Removes assumption that a failed patch is next_boot_patch in fallback behavior.

Fixes https://github.com/shorebirdtech/updater/issues/148

Type of Change

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.62%. Comparing base (435dc83) to head (732cbb3).

:exclamation: Current head 732cbb3 differs from pull request most recent head 861ccf7. Consider uploading reports for the commit 861ccf7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== + Coverage 96.45% 96.62% +0.16% ========================================== Files 20 20 Lines 2846 2841 -5 ========================================== Hits 2745 2745 + Misses 101 96 -5 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/updater/pull/149/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage ฮ” | | |---|---|---| | [library](https://app.codecov.io/gh/shorebirdtech/updater/pull/149/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `97.97% <100.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.