shorebirdtech / updater

libupdater code for Shorebird
Other
66 stars 13 forks source link

feat: Rough proof-of-concept for patch signing #152

Closed bryanoltman closed 4 months ago

bryanoltman commented 5 months ago

Description

Steps for this are detailed in https://docs.google.com/document/d/1QuOG8xPyMLwGdR9XchdR4bXposO4mZN21JNCPf2LZJc/edit

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 98.10127% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 96.57%. Comparing base (6ab6972) to head (6b7f951).

:exclamation: Current head 6b7f951 differs from pull request most recent head 65aacae

Please upload reports for the commit 65aacae to get more accurate results.

Files Patch % Lines
library/src/cache/patch_manager.rs 91.89% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== + Coverage 96.15% 96.57% +0.42% ========================================== Files 28 21 -7 Lines 3091 3157 +66 ========================================== + Hits 2972 3049 +77 + Misses 119 108 -11 ``` | [Flag](https://app.codecov.io/gh/shorebirdtech/updater/pull/152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | Coverage Δ | | |---|---|---| | [library](https://app.codecov.io/gh/shorebirdtech/updater/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `97.78% <98.10%> (-0.05%)` | :arrow_down: | | [updater_tools](https://app.codecov.io/gh/shorebirdtech/updater/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=shorebirdtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eseidel commented 4 months ago

I assume we can close this?