Warnings during cljs compilation with [org.clojure/clojurescript "0.0-2913"]

shoreleave / shoreleave-browser

A smarter client-side with ClojureScript : Shoreleave's enhanced browser utilities

Eclipse Public License 1.0

13 stars 7 forks source link

Warnings during cljs compilation with [org.clojure/clojurescript "0.0-2913"] #8

Open bilus opened 9 years ago

bilus commented 9 years ago

WARNING: Bad method signature in protocol implementation, ITransientAssociative -assoc! does not declare arity 5 at line 27 file:/Users/martinb/.m2/repository/shoreleave/shoreleave-browser/0.3.0/shoreleave-browser-0.3.0.jar!/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientMap -dissoc! does not declare arity 4 at line 27 file:/Users/martinb/.m2/repository/shoreleave/shoreleave-browser/0.3.0/shoreleave-browser-0.3.0.jar!/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientAssociative -assoc! does not declare arity 5 at line 27 resources/public/js/out/shoreleave/browser/cookies.cljs
WARNING: Bad method signature in protocol implementation, ITransientMap -dissoc! does not declare arity 4 at line 27 resources/public/js/out/shoreleave/browser/cookies.cljs

magomimmo commented 8 years ago

Just saw your old issue. That WARNING depends what they say: a bugged implementation of those two CLJS protocols (i.e. ITransientAssociative and ITransientMac) for both -assoc! and -dissoc, for a total of 4 warnings. Old version of the CLJS compiler was not able to detect this warning (that immediately become errors if your're going to use them).

Here is a patched NON CANONICAL fork

[org.clojars.magomimmo/shoreleave-browser "0.3.1"]

HIH

bilus commented 8 years ago

Thanks!