short-d / short

URL shortening service written in Go and React
https://short-d.com
MIT License
870 stars 148 forks source link

Add deletion feature to short link repository #969

Closed oatovar closed 4 years ago

oatovar commented 4 years ago

Current Behavior ( Optional for new feature )

Description

No ability to delete an existing short link. Only able to create and update.

New Behavior

Description

ShortLinkRepo now has the ability to delete a short link given an input.

oatovar commented 4 years ago

I will be pushing up the completed integration tests as well.

Coteh commented 4 years ago

LGTM

@oatovar will the integration tests be in this PR or in a separate PR?

oatovar commented 4 years ago

@Coteh they'll be included along with this PR

codecov[bot] commented 4 years ago

Codecov Report

Merging #969 into master will increase coverage by 0.11%. The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   52.46%   52.58%   +0.11%     
==========================================
  Files         142      142              
  Lines        3547     3564      +17     
  Branches      168      168              
==========================================
+ Hits         1861     1874      +13     
- Misses       1621     1623       +2     
- Partials       65       67       +2     
Flag Coverage Δ
#golang 72.03% <76.47%> (+0.03%) :arrow_up:
#typescript 22.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/app/adapter/sqldb/short_link.go 91.15% <76.47%> (-1.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4f9e93...e3cc995. Read the comment docs.

Coteh commented 4 years ago

@oatovar Thank you for your work on the delete short link feature. I have left a few more comments. Keep up the good work!