Closed oatovar closed 4 years ago
I will be pushing up the completed integration tests as well.
LGTM
@oatovar will the integration tests be in this PR or in a separate PR?
@Coteh they'll be included along with this PR
Merging #969 into master will increase coverage by
0.11%
. The diff coverage is76.47%
.
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 52.46% 52.58% +0.11%
==========================================
Files 142 142
Lines 3547 3564 +17
Branches 168 168
==========================================
+ Hits 1861 1874 +13
- Misses 1621 1623 +2
- Partials 65 67 +2
Flag | Coverage Δ | |
---|---|---|
#golang | 72.03% <76.47%> (+0.03%) |
:arrow_up: |
#typescript | 22.40% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
backend/app/adapter/sqldb/short_link.go | 91.15% <76.47%> (-1.20%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e4f9e93...e3cc995. Read the comment docs.
@oatovar Thank you for your work on the delete short link feature. I have left a few more comments. Keep up the good work!
Add
DeleteShortLink
to short link repository interface.Update sqldb adapter to implement
DeleteShortLink
.Update mock short link repo to implement
DeleteShortLink
.Current Behavior ( Optional for new feature )
Description
No ability to delete an existing short link. Only able to create and update.
New Behavior
Description
ShortLinkRepo now has the ability to delete a short link given an input.