search

short-d / short

URL shortening service written in Go and React
https://short-d.com
MIT License
870 stars 148 forks source link

Refactor invokeCreateShortLinkApi #985

Closed Dean430 closed 4 years ago

Dean430 commented 4 years ago

This is for issue https://github.com/short-d/short/issues/599 Refactor invokeCreateShortLinkApi.

codecov[bot] commented 4 years ago

Codecov Report

Merging #985 into master will increase coverage by 0.19%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   52.28%   52.48%   +0.19%     
==========================================
  Files         142      142              
  Lines        3561     3548      -13     
  Branches      173      168       -5     
==========================================
  Hits         1862     1862              
+ Misses       1634     1621      -13     
  Partials       65       65
Flag Coverage Δ
#golang 72.00% <ø> (ø)
#typescript 22.46% <0.00%> (+0.20%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/dep.ts 0.00% <ø> (ø)
frontend/src/service/GraphQLError.ts 0.00% <ø> (ø)
frontend/src/service/ShortLink.service.ts 0.00% <0.00%> (ø)
...d/src/service/shortGraphQL/ShortLinkGraphQL.api.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d504a80...e20ab18. Read the comment docs.

Dean430 commented 4 years ago

I noticed @byliuyang codecov/patch — 0.00% of diff hit (target 52.28%) is failing. Looks like we don't have any unit test for the ts files?

magicoder10 commented 4 years ago

@Dean430 You are correct. Let's add unit test for next PR.