search

shortcuts / no-neck-pain.nvim

☕ Dead simple yet super extensible plugin to center the currently focused buffer to the middle of the screen.
MIT License
576 stars 13 forks source link

The filetype is empty instead of no-neck-pain #385

Closed tadashi-aikawa closed 2 months ago

tadashi-aikawa commented 2 months ago

Description

When executing the set filetype command in the windows generated by no-neck-pain, the filetype used to be 'no-neck-pain', but now it is empty.

Additionally, I confirmed that this change was caused by the commit at https://github.com/shortcuts/no-neck-pain.nvim/commit/ba7475920e0de811768728589f6c1c7df156c803.

Steps to reproduce

  1. Open any file.
  2. Move to the window generated by no-neck-pain.
  3. Execute the set filetype command.

Then displays

filetype=

Expected behavior

filetype=no-neck-pain

Environment

shortcuts commented 2 months ago

Hey @tadashi-aikawa thanks for opening the issue and using the plugin

I thought I had a test case for that, great catch!

I'm currently working on the new major ~but will also ship the fix on the v1 branch, tagged as 1.4.2 ASAP!~ no need to fix in 1.4.1 actually, since there's no bug there, will be shipped in 1.6.1

In case you want to avoid those potential bug fixes, you can target de 1.4.1 version safely

shortcuts commented 2 months ago

ohhh it's you that owns https://minerva.mamansoft.net/Home? I usually look for "no-neck-pain.nvim" last month searches in google and always see your website :D

tadashi-aikawa commented 2 months ago

@shortcuts Thank you for your prompt response! I've confirmed that the issue has been fixed. 👍

I'm not sure what changes will be made, but I'm looking forward to the next major version update. :)

Yes, Minerva is a site where I publish what I've created with PKM. no-neck-pain.nvim is an amazing plugin that solved the problems I had with my ultrawide monitor, so I've featured it on several pages. 😊