search

shortdudey123 / chef-gluster

Chef cookbook for deploying Gluster
https://supermarket.chef.io/cookbooks/gluster
Apache License 2.0
24 stars 47 forks source link

remove `s` in backupvolfile-server in mount provider #100

Closed imatpro closed 7 years ago

imatpro commented 7 years ago

Hi,

Problem :

mount -t glusterfs -o defaults,_netdev,backupvolfile-servers=[HOST2] [HOST1]:/[VOLUME] [MOUNT_POINT]

Invalid option: backupvolfile-servers

I thinks the problem du in gluster/providers/mount.rb:88

backupvolfile-servers instead of backupvolfile-server

shortdudey123 commented 7 years ago

This reverts https://github.com/shortdudey123/chef-gluster/pull/72 Can you confirm with a doc think that this should be reverted? The current code seems correct

shortdudey123 commented 7 years ago

Hmm did some digging and it looks like the plural form that is currently in master never appears in the glusterfs codebase. @vchung-nz can you verify where you saw the plural form?

vchung-nz commented 7 years ago

Yes, I cannot find it as well. I am not using that option any more, but a manual test with backupvolfile-servers also returned invalid with glusterfs 3.9 l have now! So please go ahead and revert, sorry about any problem caused.

shortdudey123 commented 7 years ago

@vchung-nz thanks for verifying and no problem!

shortdudey123 commented 7 years ago

@imatpro let me fix up the broken testing a sec so that this does not cause master tests to fail when i merge it

imatpro commented 7 years ago

@shortdudey123 Thanks