search

shortdudey123 / chef-gluster

Chef cookbook for deploying Gluster
https://supermarket.chef.io/cookbooks/gluster
Apache License 2.0
24 stars 47 forks source link

Use GPG keys on yum repositories and Support 3.9 on yum via the buildlogs.centos.org testing repository #83

Closed chewi closed 7 years ago

chewi commented 7 years ago

I found that Kitchen had some trouble with the LVM gem stuff but it at least got as far as installing the packages so I was able to test these changes.

I'm only interested in Geo Replication, which this cookbook doesn't cover, but it's still useful for installing the packages. This feature has improved significantly in 3.9, hence why I've added support for that.

chewi commented 7 years ago

I'll file another PR on Monday. I have a custom resource for setting volume options on the way too but it needs some final tweaks.

chewi commented 7 years ago

Thanks for merging the other one, rebased this one now.

shortdudey123 commented 7 years ago

Cool, can you pull https://github.com/shortdudey123/chef-gluster/pull/83/commits/37a8ccb30a7bbbb807a951631af9185b36d08d69 out into a separate PR?

Switching to compat_resource will drop support for Chef 11 (which i am not opposed to) but i want to get everything else in, make one more minor release, then push this in for a major release

chewi commented 7 years ago

Okay, I trimmed that last commit and will file a new PR when this is merged.

shortdudey123 commented 7 years ago

Will merge once i hear back from the email i sent to gluster-users

shortdudey123 commented 7 years ago

So this is from the users list

Until someone tests and gives positive feedback they remain in buildlogs. Much the same way Fedora RPMs remain in Updates-Testing until they receive +3 karma (or wait for 14 days).

I will let this in for now, but it needs to be revisited over the next couple weeks to remove the buildlogs.centos.org logic or to fix it up to allow it to be optional

chewi commented 7 years ago

My thinking was that once 3.9 hits the main server, this clause could be bumped to 3.10. I initially wanted to make the repository URL fully configurable but that was going to be fiddly.