search

shortdudey123 / chef-salt

Chef Cookbook for Salt
https://supermarket.chef.io/cookbooks/salt
Apache License 2.0
6 stars 15 forks source link

PR for issue #34, use salt api for minion key accept #43

Open vkhatri opened 7 years ago

vkhatri commented 7 years ago

@shortdudey123 Sound reasonable. I will give it one more try.

shortdudey123 commented 7 years ago

@vkhatri hows it going on your end with the feedback? anything i can do on my end?

vkhatri commented 7 years ago

@shortdudey123 will submit a revised PR over the weekend.

shortdudey123 commented 7 years ago

Sounds good

vkhatri commented 7 years ago

@shortdudey123 Got all the changes in place, just finishing up specs.

shortdudey123 commented 7 years ago

Sounds good :)

vkhatri commented 7 years ago

Travis is failing because of an issue with yaml configuration file reported in issue #45 .

https://travis-ci.org/shortdudey123/chef-salt/jobs/210111392#L488

   +---
    +external_auth:
    +  pam:
    +    saltapi: !ruby/array:Chef::Node::ImmutableArray
    +      internal:
    +      - "@wheel"
    +      ivars:
    +        :@__path__: []
    +        :@__root__: 
    +        :@__node__: 
    +        :@__precedence__:

It would be great if you could merge this PR.

shortdudey123 commented 7 years ago

The new changes look fine in a quick skim over of them. I will review them in more detail this week. I added a comment to address the travis failure