search

shortdudey123 / chef-salt

Chef Cookbook for Salt
https://supermarket.chef.io/cookbooks/salt
Apache License 2.0
6 stars 15 forks source link

Bump apt and fix 'bootstrap' issues #8

Closed bitpusher-real closed 7 years ago

bitpusher-real commented 9 years ago

We ran into two issues when using this cookbook. One was we have a more modern version of apt in our repos, hence bumping the requirements. The second is bootstrapping this cookbook onto the first salt master, when this is in our base cookbook. Rather than creating complex logic in our base cookbook to include or not this recipe, we opted to make things fall through when there are no salt masters yet. The reason why is that we need the chef client run to complete, always. This change allows us to include the recipe on all chef nodes, regardless whether there is a salt master present. Once the salt master comes online, running chef-client manually on each node will reconfigure salt-minion to point to the master and do all the things it should do correctly.

darylrobbins commented 9 years ago

Thanks for the pull request! I don't suppose you'd have any interest in taking over the project? Since we switched from Chef to Salt, I just haven't had the time to be a responsible maintainer.

bitpusher-real commented 9 years ago

Sure, Daryl. I think we can do that. We plan on using both tools for the foreseeable future and I've got some ideas how to improve the cookbook too. Do you just want to transfer the repository to us?

-Yaakov

shortdudey123 commented 8 years ago

@bitpusher-real can you rebase on master and apply your attribute change again?

shortdudey123 commented 8 years ago

@bitpusher-real any updates on this?

shortdudey123 commented 7 years ago

Closing due to inactivity Please open a new PR if this is needed in the future