shortstheory / APStreamline

Live Video Streaming Made Easy!
GNU General Public License v3.0
117 stars 35 forks source link

Broken on Ras Pi #2

Closed stephendade closed 5 years ago

stephendade commented 5 years ago

Attempting to run on a Ras Pi 3+, I get this error when trying to connect from VLC:

pi@raspberrypi:~/APStreamline/build $ ./stream_server eth0
Interface : eth0                                                                 
Address : 192.168.0.108                                                          
Found V4L2 camera device /dev/video0                                            
/dev/video0                                                                     
Name - mmal service 16.1 Driver - bm2835 mmal                                   
Recording not started
(stream_server:4734): GStreamer-CRITICAL **: gst_element_set_state: assertion 'G ST_IS_ELEMENT (element)' failed
(stream_server:4734): GStreamer-CRITICAL **: gst_object_unref: assertion 'object  != NULL' failed
(stream_server:4734): GStreamer-CRITICAL **: gst_element_set_state: assertion 'G ST_IS_ELEMENT (element)' failed
(stream_server:4734): GStreamer-CRITICAL **: gst_object_unref: assertion 'object  != NULL' failed
Stream disconnected!

I've isolated it down to the patch 26caab4 that causes the issue.

EDIT: Fixed via putting in a missing break;after this line: https://github.com/shortstheory/adaptive-streaming/blob/ea44fb97d410a3eed88a4c7800b904bcca0f8f1b/src/RTSPStreamServer/RTSPAdaptiveStreaming.cpp#L80

Did you want me to put in a pull request for this?

shortstheory commented 5 years ago

Thank you for reporting this and taking the time to find the bug :-)

I have just pushed it in the latest commit to master, so their won't be a need to open a PR!