getUrl does use wrong method to parse url

shorwood / strapi-provider-upload-do

Strapi Upload Provider for Digital Ocean Spaces. This provider will upload to the space using the AWS S3 API.

MIT License

59 stars 32 forks source link

getUrl does use wrong method to parse url #16

Open setcooki opened 1 year ago

setcooki commented 1 year ago

Refers to:

https://github.com/shorwood/strapi-provider-upload-do/blob/34a8bcbe2d3b4af20952a23fc14d955d6be917ce/lib/index.js#L20C11-L20C11

If i use an absolute URL as CDN value (which is what its suppose to do) i get an incomplete URL returned from this method becauser URI.parseHost() should be URI.parse() - only then the method returns a valid URL

kakashigr commented 1 year ago

Same issue. Having the CDN populated in .env breaks previews and the image url does not contain the host at all

brandondeweese-reify commented 1 year ago

Having the same issue as @kakashigr.