shosetsuorg / extensions

Moved to gitlab: Shosetsu - Extensions - Universe
https://gitlab.com/shosetsuorg/extensions
GNU General Public License v3.0
58 stars 97 forks source link

Change shrink/expand URL for NovelTrench #439

Closed Xanvial closed 2 years ago

Xanvial commented 2 years ago

Update Madara code to use expandURL instead of manually concatenate the url

NovelHard changes their url structure again. So instead of just updating the keyword, might as well change the extension to ignore the keyword after base URL. This needs an update on Madara code because one of expansion of URL is not using expandURL function. Changing that allowing the extension to use custom expand/shrink URL

Xanvial commented 2 years ago

On second thought, this seems to make already added novel to library doesn't work. Is the list in library saved by the shrinked url?

So either I change the PR to update the keyword again (but will need to update this again if they change the keyword again), or keeps using this but for people with novel added to library needs to manually re-add each novel, and also will break again if novelhard changes their keyword

Xanvial commented 2 years ago

What do you think @Doomsdayrs

I think I'll just create another PR with only updated keyword