search

shosetsuorg / kotlin-lib

MOVED TO GITLAB: Shosetsu - Base Library and Lua Support
https://gitlab.com/shosetsuorg/kotlin-lib
GNU General Public License v3.0
6 stars 17 forks source link

Simplify Filter classes #30

Open Doomsdayrs opened 2 years ago

Doomsdayrs commented 2 years ago

I have a feeling that the quantity of choices in Filter are somewhat overbearing.

For example, why do we have a Switch & Checkbox. Isn't the choice unnecessary when both do the same thing? Same thing with DropDown and RadioGroup.

Is Separator even needed when it is included in a Header?

Also, List is a nightmare to code for, and should be replaced with headers.

TechnoJo4 commented 2 years ago

Some of the differences make sense. I do agree though that Switch/Checkbox is a bit redundant (remove Switch?).

DropDown and RadioGroup

You can use RadioGroup for a small amount of choices (e.g. ongoing/completed) and DropDown for large amounts (e.g. genres).

Separator/Header

I don't even remember what either of those do, I'm pretty sure you chose to create them.

List

Not sure either, but we should make sure it's really not important and can always be replaced before removing it.